[rust] fix Windows architecture detection under WOW64 - #17987
Merged
titusfortner merged 1 commit intoSep 6, 2026
Conversation
Contributor
PR Summary by QodoFix Windows architecture detection under WOW64
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Contributor
Code Review by Qodo
1.
|
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
#15363 transitioned Selenium Manager off of WMIC when Microsoft deprecated it. The PowerShell replacement was significantly less performant, so a different approach was taken by commit 9af3d6e to get the architecture value from an environment variable. Two problems with this, the first is that the variable chosen reported what the binary was built with (x86), not the architecture of the system, and the second is that the conditional used for checking the value continued to compare against WMIC values (e.g.,
contains("32")), which resulted in the defaultelsestatement always being used (ARCH_X64).I think this is likely the underlying concern of #15801. Running Selenium Manager with emulation isn't nearly as big of a deal as not being able to get native browser/driver binaries.
💥 What does this PR do?
Fixes Windows architecture detection, which has resolved every Windows host as
x86_64since 4.30.0 (verified from Plausible data)Since win64 binaries are always downloaded, 32-bit machines are completely broken since they can't run 64 bit binaries.
Windows ARM users can run x64 Selenium Manager with emulation, but the x64 versions of Firefox and Edge are likely ~1.5x less performant than the native ARM binaries will be.
🔧 Implementation Notes
GetNativeSystemInfoto get accurate architecture value and removePROCESSOR_ARCHITECTUREwhich does not give useful information.🤖 AI assistance
🔄 Types of changes
🤖 Generated with Claude Code